From: Jeff King <peff@peff.net>
Date: Wed, 26 Nov 2014 01:00:51 GMT
Subject: Re: "git notes show" is orders of magnitude slower than doing it manually with ls-tree and cat-file
Message-ID: <20141126010051.GA29830@peff.net>
In-Reply-To: <20141126004242.GA13915@glandium.org>

On Wed, Nov 26, 2014 at 09:42:42AM +0900, Mike Hommey wrote:

> I have a note tree with a bit more than 200k notes.
>
> $ time git notes --ref foo show $sha1 > /dev/null
> real    0m0.147s
> user    0m0.136s
> sys     0m0.008s
> 
> That's a lot of time, especially when you have a script that does that
> on a fair amount of sha1s.

IIRC, the notes code populates an in-memory data structure, which gives
faster per-commit lookup at the cost of some setup time. Obviously for a
single lookup, that's going to be a bad tradeoff (but it does make sense
for "git log --notes"). I don't know offhand how difficult it would be
to tune the data structure differently (or avoid it altogether) if we
know ahead of time we are only going to do a small number of lookups.
But Johan (cc'd) might.

-Peff