From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 20 Nov 2014 01:42:49 GMT
Subject: Re: [PATCH] refs.c: add a function to append a reflog entry to a fd
Message-ID: <20141120014249.GE6527@google.com>
In-Reply-To: <1416444142-28042-1-git-send-email-sbeller@google.com>

Stefan Beller wrote:

> Compared to the last send of this patch[1], there was one change in the print
> function. Replaced sprintf by snprintf for security reasons.

I prefer the version that didn't change the code while we are
extracting it into a new function.  A separate patch on top can switch
it to use strbuf_addf or xstrfmt if we want that.

My two cents,
Jonathan