From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 19 Nov 2014 02:05:03 GMT
Subject: Re: [PATCH 4/4] lock_ref_sha1_basic: do not die on locking errors
Message-ID: <20141119020503.GS6527@google.com>
In-Reply-To: <20141119014112.GA2305@peff.net>

Jeff King wrote:

> From: Ronnie Sahlberg <sahlberg@google.com>
>
> lock_ref_sha1_basic is inconsistent about when it calls
> die() and when it returns NULL to signal an error. This is
> annoying to any callers that want to recover from a locking
> error.

And in addition to the modern transaction stuff, rename_ref() has been
such a caller for a long time.

Thanks for a pleasant explanation.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

[...]
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

No need for my sign-off here --- it was just an artifact of my
forwarding the patch to the list before.