From: Jeff King <peff@peff.net>
Date: Wed, 05 Nov 2014 19:35:57 GMT
Subject: Re: [PATCH] use child_process_init() to initialize struct child_process variables
Message-ID: <20141105193557.GA12620@peff.net>
In-Reply-To: <D4F1F843014841509E8BFB9ACC7CDBCC@PhilipOakley>

On Wed, Nov 05, 2014 at 01:35:21PM -0000, Philip Oakley wrote:

> >>  2. Including two lines, like:
> [...]
> I believe that the 'two HEADs' mechanism would also fall foul of the
> 'duplicate refs' warning (untested).

It didn't in my very brief testing of what I posted above, but maybe
there is some other case that triggers it that I didn't exercise.

I grepped through the code and the only "duplicate ref" warning I see
comes from the refs.c code, which comes from commit_packed_refs(). If
the duplicate line is HEAD, I think it shouldn't trigger that, as it is
not a regular ref. That would explain why I didn't see it in my testing.

-Peff