From: Christian Couder <chriscool@tuxfamily.org>
Date: Sun, 02 Nov 2014 19:06:47 GMT
Subject: Re: [L10N] Startup of Git 2.2.0 l10n round 1
Message-ID: <20141102.200647.1807459583469654728.chriscool@tuxfamily.org>
In-Reply-To: <CAP6f5M=OqzH8R6QPxPr3yn1xCFJPA8N6q33BZGg4t8T96KaEgg@mail.gmail.com>

From: Alexander Shopov <ash@kambanaria.org>

> Can you please disambiguate message:
> msgid "more than one %s"
> 
> It means that something somewhere was repeated but does not point what
> and where. Perhaps users care about that.

If you configure something like:

[trailer "stuff"]
        key = Stuff
        key = Other

You will get:

$ echo | LANG=C git interpret-trailers
warning: more than one trailer.stuff.key

Which means that more than value was configured for the
"trailer.stuff.key" configuration option. And it makes no sense
because only one should be the canonical one.

> It is now used 3 times (trailer.c:552 trailer.c:557
> builtin/remote.c:288) but points to different things that were
> repeated. It used to mean only that there is a "remote' section
> repeated.

In builtin/remote.c the warning is also when more than one value is
given for a configuration option.

Feel free to suggest some more explicit warning in both cases if you
want. (Maybe adding " is configured" at the end would be enough.) A
patch would be even better.

Thanks,
Christian.