From: W. Trevor King <wking@tremily.us>
Date: Mon, 20 Oct 2014 15:28:09 GMT
Subject: Re: [PATCH] t1304: Set LOGNAME even if USER is unset or null
Message-ID: <20141020152809.GR17200@odin.tremily.us>
In-Reply-To: <xmqqegu3r7y7.fsf@gitster.dls.corp.google.com>

On Sun, Oct 19, 2014 at 03:49:36PM -0700, Junio C Hamano wrote:
> I'll queue this as-is, but it makes me wonder if we want to do this
> without if/then/fi, e.g.
> 
> 	: ${LOGNAME:=${USER:-$(id -u -n)}

I'm fine with that too.

> Spelling everything out with if/then/fi is obviously at the other
> extreme, i.e.

And I'm fine with this ;).

> More importantly, what if none of the alternatives work?  I
> personally feel it is OK to punt and declare test_done early,
> instead of giving false positive breakages like you saw without this
> patch.

I can put this into a v2 if you like.  Which conditional syntax do you
prefer?

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy