From: Jeff King <peff@peff.net>
Date: Mon, 29 Sep 2014 17:30:34 GMT
Subject: Re: [PATCH] Ensure SHELL_PATH is the hash bang for test suite askpass helper script.
Message-ID: <20140929173034.GA3845@peff.net>
In-Reply-To: <1411974127-5258-1-git-send-email-bdwalton@gmail.com>

On Mon, Sep 29, 2014 at 08:02:07AM +0100, Ben Walton wrote:

> The askpass script that is created for use by the test suite should
> use SHELL_PATH for its hash bang instead of /bin/sh. Commit 5a4352024
> introduced the use of idioms not supported in some legacy /bin/sh
> implementations.
> 
> Use write_script to ensure this happens automatically. This lets us
> remove the chmod step as well, since write_script handles that.
> 
> Signed-off-by: Ben Walton <bdwalton@gmail.com>

Thanks, this looks good to me.

-Peff