From: Jeff King <peff@peff.net>
Date: Tue, 23 Sep 2014 16:05:52 GMT
Subject: Re: [PATCH v3] git tag --contains: avoid stack overflow
Message-ID: <20140923160552.GA20624@peff.net>
In-Reply-To: <871tr688a4.fsf@igel.home>

On Sat, Sep 20, 2014 at 08:18:59PM +0200, Andreas Schwab wrote:

> Stepan Kasal <kasal@ucw.cz> writes:
> 
> > diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> > index 143a8ea..a911df0 100755
> > --- a/t/t7004-tag.sh
> > +++ b/t/t7004-tag.sh
> > @@ -1423,4 +1423,30 @@ EOF
> >  	test_cmp expect actual
> >  '
> >  
> > +run_with_limited_stack () {
> > +	(ulimit -s 64 && "$@")
> > +}
> 
> That is way too small.
> 
> https://build.opensuse.org/package/live_build_log/openSUSE:Factory:PowerPC/git/standard/ppc64le

Thanks for the report. I'd be OK with just giving up and dropping this
test as too flaky and system-specific to be worth the trouble.

But if we do want to keep it, does bumping it to 128 (and bumping the
4000 to 8000 in the test below it) work?

-Peff