From: Jonathan Nieder Date: Tue, 16 Sep 2014 22:23:44 GMT Subject: Re: [PATCH v5 20/35] api-lockfile: document edge cases Message-ID: <20140916222344.GT29050@google.com> In-Reply-To: <1410896036-12750-21-git-send-email-mhagger@alum.mit.edu> Michael Haggerty wrote: > * Document the behavior of commit_lock_file() when it fails, namely > that it rolls back the lock_file object and sets errno > appropriately. > > * Document the behavior of rollback_lock_file() when called for a > lock_file object that has already been committed or rolled back, > namely that it is a NOOP. I think this would be easier to read in a separate error handling section. That way, when writing new code using the lockfile API, I can quickly find what functions to use and quickly find out what the error handling conventions are --- each use of the documentation wouldn't interfere with the other. Jonathan