From: Jonathan Nieder Date: Tue, 16 Sep 2014 20:57:36 GMT Subject: Re: [PATCH v5 08/35] lock_file(): always add lock_file object to lock_file_list Message-ID: <20140916205736.GI29050@google.com> In-Reply-To: <1410896036-12750-9-git-send-email-mhagger@alum.mit.edu> Michael Haggerty wrote: > The ambiguity didn't have any ill effects, because lock_file objects > cannot be removed from the lock_file_list anyway. But it is > unnecessary to leave this behavior inconsistent. Nit: commit messages usually use present tense for current behavior (and imperative for the behavior after the patch). More importantly, the above + the diffstat don't leave me very happy about the change. Can you spell out more about the intended effect? E.g., is this about making sure other code is appropriately exercised to tolerate the signal handler even when there are a lot of errors (which should make debugging easier) or something?