From: Jeff King Date: Sat, 13 Sep 2014 20:19:38 GMT Subject: [PATCH 3/3] server-info: clean up after writing info/packs Message-ID: <20140913201938.GC27082@peff.net> In-Reply-To: <20140913201538.GA24854@peff.net> We allocate pack information in a static global list but never clean it up. This leaks memory, and means that calling update_server_info twice will generate a buggy file (it will have duplicate entries). Signed-off-by: Jeff King --- server-info.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/server-info.c b/server-info.c index d54a3d6..31f4a74 100644 --- a/server-info.c +++ b/server-info.c @@ -233,6 +233,14 @@ static void init_pack_info(const char *infofile, int force) info[i]->new_num = i; } +static void free_pack_info(void) +{ + int i; + for (i = 0; i < num_pack; i++) + free(info[i]); + free(info); +} + static int write_pack_info_file(FILE *fp) { int i; @@ -252,6 +260,7 @@ static int update_info_packs(int force) init_pack_info(infofile, force); ret = update_info_file(infofile, write_pack_info_file); + free_pack_info(); free(infofile); return ret; } -- 2.1.0.373.g91ca799