From: Max Kirillov <max@max630.net>
Date: Thu, 04 Sep 2014 14:23:22 GMT
Subject: Re: [PATCH] setup.c: set workdir when gitdir is not default
Message-ID: <20140904142322.GB8894@wheezy.local>
In-Reply-To: <CAPig+cQMNyurCB73CzGBLcfXqap5=kZsYq0O8nD29S8QsHtrBA@mail.gmail.com>

On Thu, Sep 04, 2014 at 06:44:08AM -0400, Eric Sunshine wrote:
> > +       mkdir -p subdir &&
> > +       cd subdir &&
> > +       git testalias
> 
> If a new test is added following this one, it will be run from within
> 'subdir', which might come as a surprise as the author of the new
> test. Wrapping the 'cd' and following code in a subshell is a good way
> to avoid the problem.

Sure, my mistake. Will fix this and the other issue you
mentioned. Thank you.

-- 
Max