From: Jeff King <peff@peff.net>
Date: Fri, 29 Aug 2014 22:08:19 GMT
Subject: Re: [PATCH 2/2] index-pack: handle duplicate base objects gracefully
Message-ID: <20140829220818.GA24834@peff.net>
In-Reply-To: <xmqqegvz3qpp.fsf@gitster.dls.corp.google.com>

On Fri, Aug 29, 2014 at 02:56:18PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > If a pack contains duplicates of an object, and if that
> > object has any deltas pointing at it with REF_DELTA, we will
> > try to resolve the deltas twice. While unusual, this is not
> > strictly an error, but we currently die() with an unhelpful
> > message.
> 
> Hmm, I vaguely recall Shawn declaring this as an error in the pack
> stream, though.

I agree it is probably a bug on the sending side, but I think last time
this came up we decided to try to be liberal in what we accept.  c.f.
http://thread.gmane.org/gmane.comp.version-control.git/232305/focus=232310

-Peff