From: Jonathan Nieder Date: Mon, 25 Aug 2014 19:46:41 GMT Subject: Re: [PATCH 2/3] Makefile: use `find` to determine static header dependencies Message-ID: <20140825194641.GS20185@google.com> In-Reply-To: <20140822043303.GB18192@peff.net> Jeff King wrote: > -LOCALIZED_C := $(C_OBJ:o=c) $(LIB_H) $(GENERATED_H) > +LOCALIZED_C = $(C_OBJ:o=c) $(GENERATED_H) Why is LIB_H dropped here? This would mean that po/git.pot stops including strings from macros and static inline functions in headers (e.g., in parse-options.h). The rest looks good. Thanks, Jonathan