From: Jeff King <peff@peff.net>
Date: Tue, 05 Aug 2014 18:47:24 GMT
Subject: Re: [PATCH] pack-bitmap: do not use gcc packed attribute
Message-ID: <20140805184724.GA10369@peff.net>
In-Reply-To: <53DFDCD2.2090803@gmail.com>

On Mon, Aug 04, 2014 at 09:19:46PM +0200, Karsten Blees wrote:

> Hmm, I wonder if it wouldn't be simpler to read / write the desired on-disk
> structure directly, without copying to a uchar[6] first.

Probably. My initial attempt was to keep together the read/write logic
about which sizes each item is, but I think the result ended up
unnecessarily verbose and harder to follow.

> Here's what I came up with (just a sketch, commit message is lacky and the
> helper functions deserve a better place / name):

I like it. Want to clean it up and submit in place of mine?

-Peff