From: Jeff King <peff@peff.net>
Date: Mon, 28 Jul 2014 19:16:49 GMT
Subject: Re: [PATCH v3 05/10] abspath: convert real_path_internal() to strbuf
Message-ID: <20140728191649.GE11265@peff.net>
In-Reply-To: <53D6964E.1070100@web.de>

On Mon, Jul 28, 2014 at 08:28:30PM +0200, René Scharfe wrote:

> @@ -60,26 +58,22 @@ static const char *real_path_internal(const char *path, int die_on_error)
>  			goto error_out;
>  	}
>  
> -	if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX) {
> -		if (die_on_error)
> -			die("Too long path: %.*s", 60, path);
> -		else
> -			goto error_out;
> -	}
> +	strbuf_init(&sb, 0);
> +	strbuf_addstr(&sb, path);

As with the other patch I just mentioned, should this be strbuf_reset,
not strbuf_init? We want to reset the static buffer back to zero-size,
not throw it away and leak whatever was there.

-Peff