From: John Keeping <john@keeping.me.uk>
Date: Sat, 19 Jul 2014 15:10:14 GMT
Subject: Re: [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`
Message-ID: <20140719151014.GA26927@serenity.lan>
In-Reply-To: <53CA5876.40007@kdbg.org>

On Sat, Jul 19, 2014 at 01:37:26PM +0200, Johannes Sixt wrote:
> Am 19.07.2014 11:45, schrieb John Keeping:
> > Since the argument to `--recurse-submodules` is mandatory, it does not
> > need to be stuck to the option with `=`.
> > 
> > Signed-off-by: John Keeping <john@keeping.me.uk>
> > ---
> >  contrib/completion/git-completion.bash | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> > index d0b2895..06211a6 100644
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
> >  _git_push ()
> >  {
> >  	case "$prev" in
> > +	--recurse_submodules)
> 
> This would need a dash, not an underscore.

Thanks.  I'll wait to see if there are any more comments before
re-rolling.

> > +		__gitcomp "$__git_push_recurse_submodules"
> > +		return
> > +		;;
> >  	--repo)
> >  		__gitcomp_nl "$(__git_remotes)"
> >  		return
> > 
>