From: Jeff King <peff@peff.net>
Date: Sat, 12 Jul 2014 18:07:19 GMT
Subject: Re: [PATCH 2/7] move setting of object->type to alloc_* functions
Message-ID: <20140712180719.GB13806@sigill.intra.peff.net>
In-Reply-To: <53C14C67.60300@ramsay1.demon.co.uk>

On Sat, Jul 12, 2014 at 03:55:35PM +0100, Ramsay Jones wrote:

> >  	if (!obj) {
> >  		struct commit *c = alloc_commit_node();
> > -		return create_object(sha1, OBJ_COMMIT, c);
> > +		return create_object(sha1, c);
> >  	}
> 
> perhaps:
> 	if (!obj)
> 		return create_object(sha1, alloc_commit_node());
> 
> (increasing similarity with other calls here ...)

Yeah, I noticed that but didn't change it to keep the diff small. The
one that should have is 969eba6, but it is not a big deal to do it here.

-Peff