From: Jeff King Date: Thu, 10 Jul 2014 20:50:26 GMT Subject: Re: Align git push stderr output to the same as git pull Message-ID: <20140710205026.GC4459@sigill.intra.peff.net> In-Reply-To: On Thu, Jul 10, 2014 at 03:33:47PM +1000, Sam McLeod wrote: > 'For already up-to-date repos return "Already up-to-date" which is the > same message git pull returns.' Please send your patches inline as a single body part, as generated by "git format-patch" (you can use git-send-email to send). > Developer's Certificate of Origin 1.1 You can drop the DCO here. Your Signed-off-by line is enough. > diff --git a/builtin/send-pack.c b/builtin/send-pack.c > index f420b74..6fb2642 100644 > --- a/builtin/send-pack.c > +++ b/builtin/send-pack.c > @@ -274,7 +274,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix) > } > > if (!ret && !transport_refs_pushed(remote_refs)) > - fprintf(stderr, "Everything up-to-date\n"); > + fprintf(stderr, "Already up-to-date\n"); Hrm. So this makes things consistent with git-pull, but despite the names, push and pull are not actually opposites. Push and fetch are opposites. And fetch does not say anything in the up-to-date case. So I'd somewhat wonder whether we should just be making "push" less chatty here. Still, that is a much bigger change that some people might disagree with, and I confess I don't care overly (but nor did the Everything/Already ever bother me either :) ). -Peff