From: Jeff King <peff@peff.net>
Date: Mon, 30 Jun 2014 16:46:00 GMT
Subject: Re: [PATCH v2 2/2] sha1_file: use strncmp for string comparison
Message-ID: <20140630164600.GA7641@sigill.intra.peff.net>
In-Reply-To: <53B191E6.7010509@web.de>

On Mon, Jun 30, 2014 at 06:35:50PM +0200, René Scharfe wrote:

> > It's probably not a big deal, as we don't expect random
> > junk in the pack directory, but I wonder if it would be better to be
> > explicit, like:
> 
> <snip>
> 
> Here's a simpler approach:

I agree that solves the problem. However, I'm about to post an
alternative series that also replaces has_extension with strip_suffix,
which I think ends up a bit nicer.

-Peff