From: Jeff King Date: Mon, 23 Jun 2014 17:21:37 GMT Subject: Re: [PATCH 7/7] determine_author_info: stop leaking name/email Message-ID: <20140623172136.GC4838@sigill.intra.peff.net> In-Reply-To: On Mon, Jun 23, 2014 at 11:33:56AM +0200, Erik Faye-Lund wrote: > This approach has the added benefit of fixing the case where getenv > uses a static buffer, like POSIX allows. Good point. I knew we could invalidate the pointer if setenv() was called, but I didn't know that another getenv() could (I don't know of any such implementation offhand, but it is not too hard to handle it). -Peff