From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 18 Jun 2014 19:03:59 GMT
Subject: Re: [PATCH v3 2/5] tree-walk.c: remove name_compare() function
Message-ID: <20140618190359.GS8557@google.com>
In-Reply-To: <1403117117-10384-3-git-send-email-jmmahler@gmail.com>

Jeremiah Mahler wrote:

> Remove the duplicate name_compare() function and use the one provided by
> read-cache.c.

I'd squash this into patch 1/5.

> ---
> Notes:
>     There is one small difference between the old function and the new one.
>     The old one returned -N and +N whereas the new one returns -1 and +1.
>     However, there is no place where the magnitude was needed, so this
>     change will not alter its behavior.

This is useful information for anyone looking back at the patch in the
future, so it belongs above the three-dash divider.

Thanks,
Jonathan