From: Jeff King <peff@peff.net>
Date: Wed, 18 Jun 2014 07:40:26 GMT
Subject: Re: [PATCH v4] http: fix charset detection of extract_content_type()
Message-ID: <20140618074026.GB24769@sigill.intra.peff.net>
In-Reply-To: <1403043113-12579-1-git-send-email-eungjun.yi@navercorp.com>

On Wed, Jun 18, 2014 at 07:11:53AM +0900, Yi EungJun wrote:

> From: Yi EungJun <eungjun.yi@navercorp.com>
> 
> extract_content_type() could not extract a charset parameter if the
> parameter is not the first one and there is a whitespace and a following
> semicolon just before the parameter. For example:
> 
>     text/plain; format=fixed ;charset=utf-8
> 
> And it also could not handle correctly some other cases, such as:
> 
>     text/plain; charset=utf-8; format=fixed
>     text/plain; some-param="a long value with ;semicolons;"; charset=utf-8
> 
> Thanks-to: Jeff King <peff@peff.net>
> Signed-off-by: Yi EungJun <eungjun.yi@navercorp.com>

Thanks, this version looks good to me.

-Peff