From: Michael S. Tsirkin Date: Wed, 18 Jun 2014 07:33:48 GMT Subject: Re: [PATCH RFC] git-am: support any number of signatures Message-ID: <20140618073348.GA22670@redhat.com> In-Reply-To: On Tue, Jun 17, 2014 at 11:49:11PM -0700, Junio C Hamano wrote: > On Tue, Jun 17, 2014 at 8:09 PM, Michael S. Tsirkin wrote: > > > > OK, after looking into this for a while, I realize > > this is a special property of the Signed-off-by footer. > > For now I think it's reasonable to just avoid de-duplicating > > other footers if any. Agree? > > Not really. I'd rather see "git am" hardcode as little such policy as possible. > We do need to support S-o-b footer and the policy we defined for it long time > ago, if only for backward compatiblity, but for any other footers, > policy decision > such as "dedup by default" isn't something "am" should know about. OK happily that's exactly what v2 that I just posted does. Default S-o-b footer gets the existing policy. Any other footers are added on top without any tricky deduplication. -- MST