From: Jonathan Nieder Date: Tue, 17 Jun 2014 17:48:17 GMT Subject: Re: [PATCH v2 0/3] add strnncmp() function Message-ID: <20140617174817.GQ8557@google.com> In-Reply-To: <20140617154953.GC5162@hudson.localdomain> >> On 2014-06-17 09.34, Jeremiah Mahler wrote: >>> Also, strnncmp() was switched from using memcmp() to strncmp() >>> internally to make it clear that this is meant for strings, not >>> general buffers. Why shouldn't I want to use this helper on arbitrary data? One of the advantages of other helpers in git that take a pointer and a length (e.g., the strbuf library) are that they are 8-bit clean and can work on binary data when it's useful. Thanks, Jonathan