From: Jeff King <peff@peff.net>
Date: Fri, 13 Jun 2014 23:28:42 GMT
Subject: Re: [PATCH v5 2/4] commit test: Use write_script
Message-ID: <20140613232841.GC23078@sigill>
In-Reply-To: <20140613162607.GA85151@sirius.local>

On Fri, Jun 13, 2014 at 11:26:07AM -0500, Caleb Thompson wrote:

> You're very right - I may have confused this commit message and the one
> to switch to test_set_editor. I'll rewrite this commit message.
> 
> What do you think of something like this for the description:
> 
>     Use write_script from t/test-lib-functions.sh instead of cat,
>     shebang, and chmod. This aids in readability for creating the script
>     by using the named function and allows us to turn off interpolation
>     in the heredoc of the script body to avoid extra escaping, since
>     $SHELL_PATH is handled for us.

That looks fine to me. Thanks.

-Peff