From: Jeff King <peff@peff.net>
Date: Fri, 13 Jun 2014 11:51:25 GMT
Subject: Re: [PATCHv2 5/6] t7510: test verify-commit
Message-ID: <20140613115125.GG14066@sigill.intra.peff.net>
In-Reply-To: <3aaf65288733117909150771cc62508f3236d107.1402655839.git.git@drmicha.warpmail.net>

On Fri, Jun 13, 2014 at 12:42:47PM +0200, Michael J Gruber wrote:

>  test_expect_success GPG 'detect fudged signature' '
>  	git cat-file commit master >raw &&
>  
>  	sed -e "s/seventh/7th forged/" raw >forged1 &&
>  	git hash-object -w -t commit forged1 >forged1.commit &&
> +	! git verify-commit $(cat forged1.commit) &&

Please use test_must_fail here (and further down), which will catch
things like signal death.

-Peff