From: Jeff King Date: Fri, 13 Jun 2014 07:55:51 GMT Subject: Re: [PATCH 2/3] gpg-interface: provide access to the payload Message-ID: <20140613075550.GI7908@sigill.intra.peff.net> In-Reply-To: <558044a975c940d19370394900bb44bf4fb2387d.1402063796.git.git@drmicha.warpmail.net> On Fri, Jun 06, 2014 at 04:15:27PM +0200, Michael J Gruber wrote: > diff --git a/builtin/merge.c b/builtin/merge.c > [...] > + free(signature_check.payload); > free(signature_check.gpg_output); > free(signature_check.gpg_status); > free(signature_check.signer); > [...] > diff --git a/pretty.c b/pretty.c > [...] > + free(context.signature_check.payload); > free(context.signature_check.gpg_output); > free(context.signature_check.gpg_status); > free(context.signature_check.signer); Perhaps this is a sign that we need a "signature_check_clear()" helper? -Peff