From: Christian Couder <chriscool@tuxfamily.org>
Date: Tue, 10 Jun 2014 05:12:37 GMT
Subject: Re: [PATCH 15/15] commit: record buffer length in cache
Message-ID: <20140610.071237.852310668484562387.chriscool@tuxfamily.org>
In-Reply-To: <20140609181538.GO20315@sigill.intra.peff.net>

From: Jeff King <peff@peff.net>
>
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -2313,7 +2313,7 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
>  		    ident, ident, path,
>  		    (!contents_from ? path :
>  		     (!strcmp(contents_from, "-") ? "standard input" : contents_from)));
> -	set_commit_buffer(commit, strbuf_detach(&msg, NULL));
> +	set_commit_buffer(commit, msg.buf, msg.len);

I find the above strange. I would have done something like:

-	set_commit_buffer(commit, strbuf_detach(&msg, NULL));
+	size_t size;
+	char *buf = strbuf_detach(&msg, &size);
+	set_commit_buffer(commit, buf, size);

Thanks,
Christian.