From: Stepan Kasal <kasal@ucw.cz>
Date: Thu, 05 Jun 2014 12:15:21 GMT
Subject: Re: [msysGit] Re: [PATCH] Add a Windows-specific fallback to getenv("HOME");
Message-ID: <20140605121521.GA28894@camelia.ucw.cz>
In-Reply-To: <alpine.DEB.1.00.1406051354000.14982@s15462909.onlinehome-server.info>

Hi,

On Thu, Jun 05, 2014 at 02:03:39PM +0200, Johannes Schindelin wrote:
> Render me even more convinced that the API call is the cleanest way to go,

But not me.  

In a paralel post, Duy Nguyen wrote:
> Thank you for working on pushing msysgit patches upstream. I don't use
> git on windows, but it's nice to see all windows-specific changes in
> one code base so we can try to workaround it when new patches/features
> are developed.

... but we should not obscure that more than necessary.  If the API
call is   getenv("HOME");  it helps.  And the hack with
mingw_getenv() is not that bad, so we should be pragmatic and accept
it.

Stepan