From: Christian Couder <chriscool@tuxfamily.org>
Date: Mon, 02 Jun 2014 19:16:02 GMT
Subject: Re: [PATCH v2 4/4] contrib: add convert-grafts-to-replace-refs.sh
Message-ID: <20140602.211602.2254580887425712957.chriscool@tuxfamily.org>
In-Reply-To: <CAPig+cTjJHRDQFckLqRCW0xHkMFLVbuYGrLCWHXZQoFsYY5WwA@mail.gmail.com>

From: Eric Sunshine <sunshine@sunshineco.com>

> On Sun, Jun 1, 2014 at 11:10 AM, Christian Couder
> <chriscool@tuxfamily.org> wrote:
>>
>> +test -f "$GRAFTS_FILE" || die "Could not find graft file: '$GRAFTS_FILE'"
>> +
>> +grep '^[^# ]' "$GRAFTS_FILE" | while read definition
>> +do
>> +       test -n "$definition" && {
>> +               echo "Converting: $definition"
>> +               git replace --graft $definition ||
>> +                       die "Convertion failed for: $definition"
> 
> s/Convertion/Conversion/  [1]
> 
> [1]: http://git.661346.n2.nabble.com/Re-PATCH-contrib-add-convert-grafts-to-replace-refs-sh-tp7611822.html

Ooops, sorry I forgot this.
 
>> +       }
>> +done
>> +
>> +mv "$GRAFTS_FILE" "$GRAFTS_FILE.bak" ||
>> +       die "Could not mv '$GRAFTS_FILE' to '$GRAFTS_FILE.bak'"
> 
> "Could not rename..." might be a bit more friendly to non-Unixy folk.

Ok, I will use "rename".

Thanks,
Christian.