From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 30 May 2014 18:12:42 GMT
Subject: Re: [PATCH v11 36/41] refs.c: move the check for valid refname to lock_ref_sha1_basic
Message-ID: <20140530181242.GJ12314@google.com>
In-Reply-To: <1401222360-21175-37-git-send-email-sahlberg@google.com>

Ronnie Sahlberg wrote:

> Move the check for check_refname_format from lock_any_ref_for_update
> to lock_ref_sha1_basic. At some later stage we will get rid of
> lock_any_ref_for_update completely.

Do you know if this will cause any functional change?

What is the potential impact?  Is that impact worth it?  (Given how
broken the recovery codepaths currently are, I suspect this change is
worth it, but it seems worth documenting in the log message.)

Thanks,
Jonathan