From: Jeff King <peff@peff.net>
Date: Tue, 27 May 2014 16:09:39 GMT
Subject: Re: [PATCH] config: respect '~' and '~user' in mailmap.file
Message-ID: <20140527160939.GA29693@sigill.intra.peff.net>
In-Reply-To: <1401180358-27281-1-git-send-email-oystwa@gmail.com>

On Tue, May 27, 2014 at 10:45:58AM +0200, Øystein Walle wrote:

> git_config_string() does not handle '~' and '~user' as part of the
> value. Using git_config_pathname() fixes this.

Makes sense. Curious if there was a reason we did not use it in the
first place, I looked at the history. The reason is that mailmap.file
was added in d551a48 (2009-02-08) and git_config_pathname came months
later in 395de25 (2009-11-17). Retro-fitting it now should not cause a
problem for any sane paths. So:

Reviewed-by: Jeff King <peff@peff.net>

-Peff