From: Jeremiah Mahler Date: Sun, 25 May 2014 07:44:13 GMT Subject: Re: [PATCH v2] commit: support commit.verbose and --no-verbose Message-ID: <20140525074413.GA26369@hudson.localdomain> In-Reply-To: <20140525062427.GA94219@sirius.att.net> On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote: > Incorporated changes from Duy Nguyen and Jeremiah Mahler. > ... > > +test_expect_success 'commit shows verbose diff with set commit.verbose' ' > + echo morecontent >file && > + git add file && > + test_config commit.verbose true && > + check_message message > +' This test case doesn't appear to be checking for the verbose output. No commit is made so it can't check for the presence of a diff. "check_message message" passes as it did in the test above this (not shown). -- Jeremiah Mahler jmmahler@gmail.com http://github.com/jmahler