From: Jonathan Nieder Date: Thu, 22 May 2014 19:58:08 GMT Subject: Re: [PATCH v8 00/44] Use ref transactions for all ref updates Message-ID: <20140522195808.GX12314@google.com> In-Reply-To: <1400174999-26786-1-git-send-email-sahlberg@google.com> Ronnie Sahlberg wrote: > This patch series can also be found at > https://github.com/rsahlberg/git/tree/ref-transactions Thoughts on 65a1cb7b (2014-05-22 12:08): 01/40 remove ref_transaction_rollback Reviewed-by: Jonathan Nieder 02/40 constify the sha arguments for ref_transaction_create|delete|update still Reviewed-by: Jonathan Nieder 03/40 allow passing NULL to ref_transaction_free The third paragraph ("This allows us to write code like") is still confusing. Why not drop that paragraph? 04/40 --- oh, lunch time. Will pick up when I get back. Thanks, Jonathan