From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 21 May 2014 22:07:10 GMT
Subject: Re: [PATCH v8 32/44] refs.c: remove the update_ref_write function
Message-ID: <20140521220710.GG12314@google.com>
In-Reply-To: <1400174999-26786-33-git-send-email-sahlberg@google.com>

Ronnie Sahlberg wrote:

> +++ b/refs.c
[...]
> @@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction *transaction,
>  		struct ref_update *update = updates[i];
>  
>  		if (!is_null_sha1(update->new_sha1)) {
> -			ret = update_ref_write(msg,
> -					       update->refname,
> -					       update->new_sha1,
> -					       update->lock, err,
> -					       UPDATE_REFS_QUIET_ON_ERR);
> +			ret = write_ref_sha1(update->lock, update->new_sha1,
> +					     msg);

This changes the return value on error from 1 to -1.  That seems like a
good change.  It's probably worth mentioning in the commit message.