From: Jeremiah Mahler Date: Wed, 21 May 2014 21:50:59 GMT Subject: Re: [PATCH v6] format-patch --signature-file Message-ID: <20140521215059.GB13956@hudson.localdomain> In-Reply-To: On Wed, May 21, 2014 at 02:13:06PM -0700, Junio C Hamano wrote: > Jeremiah Mahler writes: > ... > > ! grep "^-- \$" output ... > > We have been trying not to do the above in recent test updates. It > would be nice if this set-up did not have to be outside of the usual > test_expect_success structure. > Jeff caught those "! grep" instances in my patch. I can submit a separate patch to fix instances like those in test cases unrelated to this signature-file patch. -- Jeremiah Mahler jmmahler@gmail.com http://github.com/jmahler