From: Jeff King Date: Sat, 17 May 2014 07:05:18 GMT Subject: Re: [PATCH v2 07/10] replace: die early if replace ref already exists Message-ID: <20140517070518.GD13003@sigill.intra.peff.net> In-Reply-To: <20140517064133.18932.92343.chriscool@tuxfamily.org> On Sat, May 17, 2014 at 08:41:29AM +0200, Christian Couder wrote: > If a replace ref already exists for an object, it is > much better for the user if we error out before we > let the user edit the object, rather than after. Definitely. Code looks fine to me. -Peff