From: Jeff Sipek <jeffpc@josefsipek.net>
Date: Thu, 15 May 2014 23:21:12 GMT
Subject: Re: [GUILT v2 15/29] Produce legal patch names in guilt-import-commit.
Message-ID: <20140515232112.GD1334@meili.valhalla.31bits.net>
In-Reply-To: <1400013065-27919-16-git-send-email-cederp@opera.com>

On Tue, May 13, 2014 at 10:30:51PM +0200, Per Cederqvist wrote:
> Try harder to create patch names that adhere to the rules in
> git-check-ref-format(1) when deriving a patch name from the commit
> message.  Verify that the derived name using "git check-ref-format",
> and as a final fallback simply use the patch name "x" (to ensure that
> the code is future-proof in case new rules are added in the future).
> 
> Always append a ".patch" suffix to the patch name.
> 
> Added test cases.

Also very nice.

Thanks,

Jeff.

Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>

-- 
We have joy, we have fun, we have Linux on a Sun...