From: Jonathan Nieder Date: Thu, 15 May 2014 19:44:56 GMT Subject: Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status Message-ID: <20140515194456.GI26471@google.com> In-Reply-To: <1400174999-26786-12-git-send-email-sahlberg@google.com> Ronnie Sahlberg wrote: > Do basic error checking in ref_transaction_create() and make it return > non-zero on error. Same thoughts as _update(). Basic idea is good but would be nice to have a 'struct strbuf *err' parameter. Thanks, Jonathan