From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 15 May 2014 19:23:15 GMT
Subject: Re: [PATCH v8 08/44] update-ref.c: log transaction error from the update_ref
Message-ID: <20140515192315.GG26471@google.com>
In-Reply-To: <1400174999-26786-9-git-send-email-sahlberg@google.com>

Ronnie Sahlberg wrote:

> Call ref_transaction_commit with QUIET_ON_ERR and use the strbuf that is
> returned to print a log message if/after the transaction fails.
>
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>

All error paths in _commit add to the error string now, so the only
effect should be to add the missing error message when commiting
packed-refs fails (thanks for fixing that) and to change some one-line
errors to two-line.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>