From: Phil Pennock <phil.pennock@spodhuis.org>
Date: Wed, 30 Apr 2014 19:44:29 GMT
Subject: Re: [PATCH] zsh completion: 5.0.3 compat, use emulate
Message-ID: <20140430194429.GC85829@redoubt.spodhuis.org>
In-Reply-To: <5360c9d095f5c_47db12fd310ef@nysa.notmuch>

On 2014-04-30 at 05:00 -0500, Felipe Contreras wrote:
> Felipe Contreras wrote:
> > Phil Pennock wrote:
> > > The bash completion pulled into zsh was being pulled in _as_ zsh, but
> > > used patterns which relied on falling through as unhandled.  In zsh
> > > 5.0.3 this no longer works, resulting in:
> > > 
> > >     __git_complete_remote_or_refspec:33: bad pattern: +*
> > > 
> > > Fix by telling zsh to emulate sh while sourcing the bash config file,
> > > which stickily preserves compatibility options in the function context.
> > > This usage of "emulate" came in with zsh 4.3.10, released 2009-06-01.
> > 
> > I'm using 5.9.5 and I don't see any issue. Howe exactly have you
> > configured this script?
> 
> I meant 5.0.5.
> 
> Anyway, I've tried with multiple versions of zsh and I'm able to
> reproduce the issue by doing 'git push origin <tab>'. However, it seems
> the issue was instroduced in 5.0.3, and fixed in 5.0.4, so I don't think
> we should do anything on our side.

Correct: it was considered a regression and after I mailed the git list,
zsh changed the behaviour and put out 5.0.4 fairly shortly thereafter.
I don't think that 5.0.3 has taken root anywhere, so you should be good.

-Phil