From: Jonathan Nieder Date: Fri, 25 Apr 2014 22:47:14 GMT Subject: Re: [PATCH v3 07/19] refs.c: remove the onerr argument to ref_transaction_commit Message-ID: <20140425224714.GF9218@google.com> In-Reply-To: <1398442494-23438-8-git-send-email-sahlberg@google.com> Ronnie Sahlberg wrote: > Since we now pass meaningful error messages back from ref_transaction_commit > on failures, we no longer need to provide a onerr argument. Yay! More precisely, now that all callers use UPDATE_REFS_QUIET_ON_ERR there's no need to support any other behavior. Thanks for cleaning up the error handling here.