From: Jonathan Nieder Date: Fri, 25 Apr 2014 22:45:07 GMT Subject: Re: [PATCH v3 06/19] refs.c: make update_ref_write to return error string on failure Message-ID: <20140425224507.GE9218@google.com> In-Reply-To: <1398442494-23438-7-git-send-email-sahlberg@google.com> Ronnie Sahlberg wrote: > Change update_ref_write to also return an error string on failure. > This makes the error avaialbel to ref_transaction_commit callers if the > transaction failed dur to update_ref_sha1/write_ref_sha1 failures. Nits: * available * during Probably should come right after or before patch 3. Same nit as patch 3 about using asprintf or passing in a pointer to strbuf.