From: Jeff King <peff@peff.net>
Date: Wed, 23 Apr 2014 20:55:33 GMT
Subject: Re: [PATCH v2] git tag --contains : avoid stack overflow
Message-ID: <20140423205533.GA20582@sigill.intra.peff.net>
In-Reply-To: <xmqqk3afydq2.fsf@gitster.dls.corp.google.com>

On Wed, Apr 23, 2014 at 01:48:05PM -0700, Junio C Hamano wrote:

> > I don't think so. The point is that we _must_ use bash here, not any
> > POSIX shell.
> 
> Sorry, but I do not understand.  Isn't what you want "any POSIX
> shell with 'ulimit -s 64' supported"?

Sure, that would be fine, but the original patch which started this
thread claimed that bash was required. I had assumed that to be true,
but it seems like it's not:

>     $ dash -c 'ulimit -s && ulimit -s 64 && ulimit -s'
>     8192
>     64

If we are just using the same shell we are already running, then why
invoke it by name in the first place? IOW, why not:

  run_with_limited_stack () {
	(ulimit -s 64 && "$@")
  }

-Peff