From: Jeff King <peff@peff.net>
Date: Tue, 01 Apr 2014 19:59:30 GMT
Subject: Re: [PATCH 04/22] rollback_lock_file(): set fd to -1
Message-ID: <20140401195930.GC21715@sigill.intra.peff.net>
In-Reply-To: <1396367910-7299-5-git-send-email-mhagger@alum.mit.edu>

On Tue, Apr 01, 2014 at 05:58:12PM +0200, Michael Haggerty wrote:

> When rolling back the lockfile, call close_lock_file() so that the
> lock_file's fd field gets set back to -1.  This could help prevent
> confusion in the face of hypothetical future programming errors.

This also solves a race. We could be in the middle of rollback_lock_file
when we get a signal, and double-close. It's probably not a big deal,
though, since nobody could have opened a new descriptor in the interim
that got the same number (so the second close will just fail silently).

Still, this seems like a definite improvement.

-Peff