From: Jeff King <peff@peff.net>
Date: Thu, 27 Mar 2014 23:11:56 GMT
Subject: Re: SSL_CTX leak?
Message-ID: <20140327231156.GE32434@sigill.intra.peff.net>
In-Reply-To: <CACnwZYdYYO2VXRnfyVD_uEeguYcBv-eFoYfawoCESDbcBVMhgA@mail.gmail.com>

On Thu, Mar 27, 2014 at 10:37:07AM -0300, Thiago Farina wrote:

> Do we leak the context we allocate in imap-send.c:280 intentionally?

It was never mentioned on the mailing list when the patches came
originally, so I suspect is just an omission.

Presumably the SSL_CTX is needed by the connection that survives after
the function, but my reading of SSL_CTX_free implies that the data is
reference-counted, and the library would presumably handle it fine.

OTOH, it is probably not causing a huge problem (since we wouldn't end
up freeing it until the end of the program anyway), so I would not
personally devote to many brain cycles to figuring out how OpenSSL
handles it.

-Peff