From: Jeff King <peff@peff.net>
Date: Tue, 25 Mar 2014 21:42:33 GMT
Subject: Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers
Message-ID: <20140325214232.GA18217@sigill.intra.peff.net>
In-Reply-To: <5331E1F6.1070506@kdbg.org>

On Tue, Mar 25, 2014 at 09:07:18PM +0100, Johannes Sixt wrote:

> Am 24.03.2014 22:39, schrieb Jeff King:
> > On Mon, Mar 24, 2014 at 05:36:59PM -0400, Jeff King wrote:
> > 
> >>> +How to write RIGHT test cases
> >>> +=============================
> >>> +
> >>> +Insert the word "ChangeMe" (exactly this form) at a distance of
> >>> +at least two lines from the line that must appear in the hunk header.
> >>
> >> The existing tests use -U1 to make writing cases simpler. Is there a
> >> reason not to continue that (or if you found that porting the existing
> >> cases was not a chore with -U3, I can buy that argument, too)?
> > 
> > I take it back. You did keep "-U1" in the result. Is this "two lines"
> > rule necessary, then?
> 
> When we have
> 
>    one
>    two
>    three
> 
> how would you describe the distance between "one" and "three"?

I read it as "two lines between". Though that would be appropriate for
-U2, so I think I probably had an off-by-one in my head, then, too.

So it is probably fine as-is, and this was mostly just me confusing
myself. Sorry for the noise.

-Peff