From: Jeff King <peff@peff.net>
Date: Mon, 24 Mar 2014 21:49:54 GMT
Subject: Re: [PATCH 00/10] userdiff: cpp pattern simplification and test framework
Message-ID: <20140324214954.GG13728@sigill.intra.peff.net>
In-Reply-To: <cover.1395433874.git.j6t@kdbg.org>

On Fri, Mar 21, 2014 at 10:07:12PM +0100, Johannes Sixt wrote:

> Here is a series that makes the hunk header pattern for C and C++ even
> simpler than suggested by Peff in [1] to catch a lot more C++ functions
> and two more C patterns.
> 
> As a preparatory work, the test cases are totally rewritten to make it
> a lot simpler to drop in new tests. There was an earlier attempt to
> change the infrastructure [2], and it is the reason for the widened Cc
> list.

Thanks. This looks sane overall, and I am especially happy about the
increased test coverage. I do not know if your 10/10 misses some cases,
but at least now we can collect and reason about a set of examples going
forward.

-Peff