From: Jeff King Date: Mon, 24 Mar 2014 21:39:13 GMT Subject: Re: [PATCH 03/10] t4018: an infrastructure to test hunk headers Message-ID: <20140324213913.GA14890@sigill.intra.peff.net> In-Reply-To: <20140324213659.GF13728@sigill.intra.peff.net> On Mon, Mar 24, 2014 at 05:36:59PM -0400, Jeff King wrote: > > +How to write RIGHT test cases > > +============================= > > + > > +Insert the word "ChangeMe" (exactly this form) at a distance of > > +at least two lines from the line that must appear in the hunk header. > > The existing tests use -U1 to make writing cases simpler. Is there a > reason not to continue that (or if you found that porting the existing > cases was not a chore with -U3, I can buy that argument, too)? I take it back. You did keep "-U1" in the result. Is this "two lines" rule necessary, then? -Peff